Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw background first in 2d.composite.canvas WPT tests #50259

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 23, 2025

All other 2d.composite tests draw the background first and then draw the
foreground. By using the same standard layout, it will be easier to
merge the test body of all the 2d.composite tests, using a single common
implementation.

Bug: 40207206
Change-Id: I6c7fdd90e99b18f29deeca83e50e92a4a1ea8f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192520
Reviewed-by: Andres Ricardo Perez <[email protected]>
Commit-Queue: Jean-Philippe Gravel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1411633}

All other 2d.composite tests draw the background first and then draw the
foreground. By using the same standard layout, it will be easier to
merge the test body of all the 2d.composite tests, using a single common
implementation.

Bug: 40207206
Change-Id: I6c7fdd90e99b18f29deeca83e50e92a4a1ea8f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192520
Reviewed-by: Andres Ricardo Perez <[email protected]>
Commit-Queue: Jean-Philippe Gravel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1411633}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7748c44 into master Jan 27, 2025
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-6192520 branch January 27, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants